Allow doctests to span multiple lines with a trailing \ like the REPL already supports #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… already supports Additionally this allows empty doctest lines to be skipped without error
|
Docstrings were meant to work like the REPL - this was an omission in the initial implementation |
RyanGlScott
reviewed
Sep 27, 2024
| where | ||
| -- concat that eats leading whitespace between elements | ||
| concat' [] = T.empty | ||
| concat' (y:ys) = T.concat (y : map (T.dropWhile isSpace) ys) |
There was a problem hiding this comment.
What happens if you have an example like this?
/**
** ```repl
** :check f 1\
** 0
** ``` */
Does this get interpreted as :check f 10 or :check f 1 0?
There was a problem hiding this comment.
It gets interpreted as 10 which is consistent with C (as an example). This will be useful for long literals, too:
x = 0x0123456789abcdef\
0123456789abcdef\
0123456789abcdef
There was a problem hiding this comment.
That makes sense—thanks for the explanation. It might be worth testing this property in the T02 test case.
RyanGlScott
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally this allows empty doctest lines to be skipped without error